herdr-webui halfblocks: protocol gate test, lint debt cleanup, CI validity fix

.github/workflows/ci.yml

@@ -1,8 +1,5 @@
 name: CI
 
-env:
-  JCODE_CI: "1"
-
 on:
   push:
     branches: [main, master]
@@ -14,6 +11,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
+  JCODE_CI: "1"
   CARGO_TERM_COLOR: always
   SCCACHE_GHA_ENABLED: "true"
 
@@ -30,8 +28,11 @@ jobs:
 
       - name: Configure SSH for cargo git dependencies
         uses: webfactory/ssh-agent@v0.9.0
+        if: env.DEPLOY_KEY != ''
+        env:
+          DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}
         with:
-          ssh-private-key: ${{ secrets.DEPLOY_KEY }}
+          ssh-private-key: ${{ env.DEPLOY_KEY }}
 
       - uses: dtolnay/rust-toolchain@stable
         with:
@@ -156,8 +157,11 @@ jobs:
 
       - name: Configure SSH for cargo git dependencies
         uses: webfactory/ssh-agent@v0.9.0
+        if: env.DEPLOY_KEY != ''
+        env:
+          DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}
         with:
-          ssh-private-key: ${{ secrets.DEPLOY_KEY }}
+          ssh-private-key: ${{ env.DEPLOY_KEY }}
 
       - uses: dtolnay/rust-toolchain@stable
         with:
@@ -396,8 +400,11 @@ jobs:
 
       - name: Configure SSH for cargo git dependencies
         uses: webfactory/ssh-agent@v0.9.0
+        if: env.DEPLOY_KEY != ''
+        env:
+          DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}
         with:
-          ssh-private-key: ${{ secrets.DEPLOY_KEY }}
+          ssh-private-key: ${{ env.DEPLOY_KEY }}
 
       - uses: ilammy/msvc-dev-cmd@v1
         with:
@@ -649,8 +656,11 @@ jobs:
 
       - name: Configure SSH for cargo git dependencies
         uses: webfactory/ssh-agent@v0.9.0
+        if: env.DEPLOY_KEY != ''
+        env:
+          DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}
         with:
-          ssh-private-key: ${{ secrets.DEPLOY_KEY }}
+          ssh-private-key: ${{ env.DEPLOY_KEY }}
 
       - uses: dtolnay/rust-toolchain@stable
         with:

AGENTS.md

@@ -2,6 +2,19 @@
 
 ## Development Workflow
 
+- **Commit as you go** - Make small, focused commits after completing each feature or fix
+- If the git state is not clean, or there are other agents working in the codebase in parallel, do your best to still commit your work. 
+- **Push when done** - Push all commits to remote when finishing a task or session
+- **Use fast iteration by default** - Prefer `cargo check`, targeted tests, and dev builds while iterating
+- **Rebuild when done** - When you are done making changes, build the source.
+- **Bump version for releases** - Update version in `Cargo.toml` when making releases. When cutting a new release, look at all the changes that happened since the last release and determine what the version bump should be ie patch or minor, etc. 
+- **Remote builds available** - Use `scripts/remote_build.sh` to offload heavy cargo work to another machine. If your build is terminated, likely is because there are not enough resources on this machine to build. use remote build in that case. Try checking the resource avaliablity on the machine before you run a build. 
+
+## Logs
+- Logs are written to `~/.jcode/logs/` (daily files like `jcode-YYYY-MM-DD.log`).
+
+## Debug Socket
+- Use the debug socket for runtime level debugging
 - **Use the user's Git identity** - Create commits with the configured
   `user.name` and `user.email`. Do not override them with `Jcode`, `Jcode agent`,
   or a fabricated agent email. Preserve existing contributor attribution when

crates/jcode-app-core/src/agent_tests.rs

@@ -1782,12 +1782,17 @@ fn empty_post_tool_response_gets_more_than_one_retry() {
     // transient hiccup, not a finished task. With only one retry allowed, a
     // single empty response (observed once in 43 turns) ended a 20-hour agent
     // run with the work half-done and the submission unoptimized.
-    assert!(
-        Agent::MAX_EMPTY_POST_TOOL_CONTINUATION_ATTEMPTS > 1,
-        "a single retry lets one transient empty response end a long run"
-    );
-    // Bounded, so a genuinely finished agent still exits instead of looping.
-    assert!(Agent::MAX_EMPTY_POST_TOOL_CONTINUATION_ATTEMPTS <= 10);
+    // assertions_on_constants fires because both bounds are compile-known; the
+    // guard is kept as a readable regression test, not dead code.
+    #[allow(clippy::assertions_on_constants)]
+    {
+        assert!(
+            Agent::MAX_EMPTY_POST_TOOL_CONTINUATION_ATTEMPTS > 1,
+            "a single retry lets one transient empty response end a long run"
+        );
+        // Bounded, so a genuinely finished agent still exits instead of looping.
+        assert!(Agent::MAX_EMPTY_POST_TOOL_CONTINUATION_ATTEMPTS <= 10);
+    }
 }
 
 #[test]

crates/jcode-app-core/src/network_retry.rs

@@ -81,12 +81,12 @@ pub fn wait_plan() -> NetworkWaitPlan {
     }
     #[cfg(target_os = "macos")]
     {
-        return NetworkWaitPlan {
+        NetworkWaitPlan {
             reason: "stream interrupted by a likely network disconnect".to_string(),
             listener_summary:
                 "listening for macOS route/interface changes via `route -n monitor`; also verifying with reconnect probes"
                     .to_string(),
-        };
+        }
     }
     #[cfg(not(any(target_os = "linux", target_os = "macos")))]
     {

crates/jcode-app-core/src/server/background_tasks.rs

@@ -583,6 +583,41 @@ fn cap_chars(s: &str, cap: usize) -> String {
     out
 }
 
+pub(super) async fn dispatch_ui_activity(
+    activity: &crate::bus::UiActivity,
+    swarm_members: &Arc<RwLock<HashMap<String, SwarmMember>>>,
+) {
+    if activity.message.trim().is_empty() {
+        return;
+    }
+    let Some(session_id) = activity.session_id.as_deref() else {
+        return;
+    };
+
+    if fanout_session_event(
+        swarm_members,
+        session_id,
+        ServerEvent::Notification {
+            from_session: "jcode".to_string(),
+            from_name: Some("Jcode".to_string()),
+            notification_type: NotificationType::Message {
+                scope: Some(activity.kind.scope().to_string()),
+                channel: None,
+                tldr: None,
+            },
+            message: activity.message.clone(),
+        },
+    )
+    .await
+        == 0
+    {
+        crate::logging::warn(&format!(
+            "Failed to notify attached clients for UI activity on session {}",
+            session_id
+        ));
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -673,38 +708,3 @@ mod tests {
         assert!(!update_active_todo_batch_progress(&mut items, &progress));
     }
 }
-
-pub(super) async fn dispatch_ui_activity(
-    activity: &crate::bus::UiActivity,
-    swarm_members: &Arc<RwLock<HashMap<String, SwarmMember>>>,
-) {
-    if activity.message.trim().is_empty() {
-        return;
-    }
-    let Some(session_id) = activity.session_id.as_deref() else {
-        return;
-    };
-
-    if fanout_session_event(
-        swarm_members,
-        session_id,
-        ServerEvent::Notification {
-            from_session: "jcode".to_string(),
-            from_name: Some("Jcode".to_string()),
-            notification_type: NotificationType::Message {
-                scope: Some(activity.kind.scope().to_string()),
-                channel: None,
-                tldr: None,
-            },
-            message: activity.message.clone(),
-        },
-    )
-    .await
-        == 0
-    {
-        crate::logging::warn(&format!(
-            "Failed to notify attached clients for UI activity on session {}",
-            session_id
-        ));
-    }
-}

crates/jcode-app-core/src/server/client_lifecycle.rs

@@ -1297,10 +1297,8 @@ pub(super) async fn handle_client(
                         active_turn_registered,
                         session_connection_busy,
                     );
-                    if start {
-                        if let Some(info) = connections.get_mut(&client_connection_id) {
-                            info.is_processing = true;
-                        }
+                    if start && let Some(info) = connections.get_mut(&client_connection_id) {
+                        info.is_processing = true;
                     }
                     start
                 };

crates/jcode-app-core/src/server/client_lifecycle_tests.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::await_holding_lock)] // env guards held across async test bodies
 use super::*;
 use crate::message::{ContentBlock, Message, StreamEvent, ToolDefinition};
 use crate::provider::{EventStream, Provider};

crates/jcode-app-core/src/server/comm_session.rs

@@ -549,10 +549,6 @@ async fn register_visible_spawned_member(
     broadcast_swarm_status(swarm_id, swarm_members, swarms_by_id).await;
 }
 
-#[expect(
-    clippy::too_many_arguments,
-    reason = "server-side swarm spawning needs session, swarm state, provider, and event sinks together"
-)]
 /// Resolve the reasoning effort for a spawned swarm worker (#1165).
 ///
 /// Precedence mirrors the model path: an explicit `effort` on the spawn call
@@ -571,6 +567,10 @@ pub(super) fn resolve_swarm_spawn_effort(
     clean(requested_effort).or_else(|| clean(configured_swarm_effort))
 }
 
+#[expect(
+    clippy::too_many_arguments,
+    reason = "server-side swarm spawning needs session, swarm state, provider, and event sinks together"
+)]
 pub(super) async fn spawn_swarm_agent(
     req_session_id: &str,
     swarm_id: &str,

crates/jcode-app-core/src/server/debug_command_exec.rs

@@ -653,7 +653,7 @@ mod tests {
     use jcode_agent_runtime::InterruptSignal;
     use std::collections::HashMap;
     use std::ffi::OsString;
-    use std::sync::{Arc, Mutex, OnceLock};
+    use std::sync::Arc;
     use std::time::{Duration, Instant};
     use tokio::sync::{Mutex as AsyncMutex, RwLock};