[docs-agent] Fix Solana DAS options schema (showInscription typo + add missing options param)#1315
Open
JackReacher0807 wants to merge 1 commit into
Open
[docs-agent] Fix Solana DAS options schema (showInscription typo + add missing options param)#1315JackReacher0807 wants to merge 1 commit into
JackReacher0807 wants to merge 1 commit into
Conversation
…d missing options param) Update the shared DisplayOptions schema in chains/_components/solana/asset.yaml to match what the Alchemy DAS proxy actually accepts: * rename showInscriptions -> showInscription (typo fix; backend rejects the plural spelling) * remove showNativeBalance and showGrandTotal (not accepted by the backend) * tighten property descriptions to match the searchAssets reference Update src/openrpc/alchemy/solana-das/solana-das.yaml so all 6 affected methods carry the same alias note searchAssets uses (`options` and `displayOptions` are server-side aliases; only one may be present): * getAsset, getAssets: refresh the existing displayOptions description * getAssetsByOwner: refresh the existing options description * getAssetsByAuthority, getAssetsByCreator, getAssetsByGroup: add the missing options parameter referencing the shared DisplayOptions schema Verified against solana-mainnet.g.alchemy.com/v2/docs-demo: the 5-flag schema (showUnverifiedCollections, showCollectionMetadata, showZeroBalance, showInscription, showFungible) is enumerated verbatim in the server's "unknown field ... expected one of ..." error, and all 3 newly-augmented methods return real data when called with the documented options shape. Refs DOCS-92 Requested-by: @victorbware
🔗 Preview Mode
|
🔍 Link CheckStatus: ⏭️ Skipped (no content changes) |
victorbware
previously approved these changes
May 21, 2026
github-actions
Bot
dismissed
victorbware’s stale review
@victorbware you are listed as the originator of this docs request (via the Requested-by trailer on a docs-agent commit). Per the docs-agent self-review policy, the originator can't approve their own request. Please ask another team member to review.
dslovinsky
approved these changes
May 21, 2026
SahilAujla
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Solana DAS API docs listed a
displayOptions/optionsschema that was out of sync with what the Alchemy DAS proxy actually accepts, scattered across six methods. This PR aligns the spec with the live backend.Confirmed against
solana-mainnet.g.alchemy.com/v2/docs-demo— the server enumerates the canonical 5-flag set verbatim in itsunknown field ... expected one of ...error:All boolean, all default
false. NoteshowInscriptionis singular.Shared
DisplayOptionsschema (src/openrpc/chains/_components/solana/asset.yaml)showInscriptions→showInscription(the plural spelling is rejected by the backend).showNativeBalance(rejected).showGrandTotal(rejected).searchAssetsreference.Per-method updates (
src/openrpc/alchemy/solana-das/solana-das.yaml)getAssetdisplayOptionsdescription with theoptionsalias note.getAssetsgetAssetsByOwneroptionsdescription with thedisplayOptionsalias note.getAssetsByAuthorityoptionsparam using the shared schema.getAssetsByCreatoroptionsparam using the shared schema.getAssetsByGroupoptionsparam using the shared schema.All six methods now mirror the alias note pattern from
searchAssets: the backend accepts bothoptionsanddisplayOptionsas aliases, but only one may be present per request (duplicate fielderror otherwise, confirmed live).Verification
pnpm run generate:rpc✅pnpm run validate:rpc✅solana-mainnet.g.alchemy.com/v2/docs-demo:getAssetwith the new 5-flagdisplayOptions→ 200 with the requested asset.getAssetsByGroupwithoptions.showCollectionMetadata: true→ 200 with 2 items.getAssetsByAuthoritywithdisplayOptionsalias → 200 with 2 items.getAssetsByAuthoritywith BOTHoptionsanddisplayOptionsset →duplicate fielderror (confirms the alias note's "only one may be present" caveat).Linear
DOCS-92
Requested by
@victorbware (via Slack thread)