Repository navigation
Report shaper completion only after acceptance - #46
Merged
Merged
Conversation
The Shaper conversation claimed "Change complete" as soon as an authored-app proposal latched, before the controller staged and accepted the capsule. A staging failure after that message left the conversation asserting success while the canvas stayed unchanged. The turn now latches an app archive without a completion message, and the controller concludes the turn through the new typed AgentWorkspace.concludeShaperTurn capability: "Change complete: <name>" is appended only after local acceptance succeeds, a staging failure appends a bounded "The app could not be activated" message and sets the shaper status to error while the canvas stays last-known-good, and a blocked review announces nothing because the explicit Activate/Discard candidate takes over. Document outcomes keep their latch-time message; their acceptance is the immediate local revision in the same operation. ADR 0005's known follow-up paragraph now records the implemented sequencing. Claude-Session: https://claude.ai/code/session_01VNmFXmRMNV98Hyd3xogUuK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0005 follow-up: the conversation claimed "Change complete" at proposal-latch time, slightly before the controller finished acceptance - a staging failure after that message left a false success in the timeline.
AgentWorkspaceShape.concludeShaperTurncapability: exactly one "Change complete" after real acceptance; on staging failure, a bounded "The app could not be activated: . Your previous canvas is unchanged." with error status.Evidence: full unit suite green (920 passed), full Playwright suite green (94 passed) on this branch; new unit coverage for both conclusion paths including a forced git-checkpoint failure.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VNmFXmRMNV98Hyd3xogUuK