Repository navigation
chore(deps): comicbox 5.6.0 - #1007
Merged
Merged
Conversation
comicbox 5.6.0 changes only the filename format: filenames now read the month, day, volume count and publisher, renames write the full date and volume count but never the publisher, and `(Digital)` / `(DC)` alone no longer parse as the title. comicfn2dict 1.1 and comicbox-pdffile 1.1.2 come along. codex needs no code change. None of the new filename keys is a new top-level comicbox field, so the derived delete_keys list is unchanged and `remainders` is still dropped before a rename. The rename preview goes through predict_filename, so it shows the new names as is. Checked on metadata-less CBZs through COMICBOX_CONFIG: publisher, full date and original_format are imported, and the predicted names match comicbox's new format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ty 0.0.99, already locked on develop, renamed the rule. The old name now raises renamed-rule-in-ignore-comment, which fails `make ty`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
comicbox[pdf]~=5.6.0and re-locks. comicfn2dict 1.0.2 → 1.1.0 comes along; comicbox-pdffile was already 1.1.2.# ty: ignore[unresolved-import]comments toimport-not-found(separate commit).Why
comicbox 5.6.0 changes only the filename format. For comics without embedded tags, the filename now supplies the month, day, volume count and publisher, and
(Digital)or(DC)alone no longer reads as the title. Renames write the full date and the volume count, never the publisher.Codex needs no code change for it:
date,publisher,series), so the deriveddelete_keyslist is unchanged andremaindersis still dropped before a rename.predict_filename, so they show the new names as is.The ty commit is unrelated to comicbox. develop already locks ty 0.0.99, which renamed the rule, so
make tyfailed there.Verification
make fix,make lint,make typecheckandmake tyare clean.make build-choicesoutput is unchanged.COMICBOX_CONFIG.Batman (DC) v2 #001 (1950-11-01).cbzimports publisherDCand the full date.Batman #001 (Digital) (2020-12).cbzimportsoriginal_formatDigitaland year plus month, with no title. Predicted renames come out asBatman v2 (of 003) #001 (1950-11-01).cbz.For reviewers
(of 003)even when there's no volume number, and that form doesn't read back. It ends up inremainders. The fix belongs in comicfn2dict'sunparse.py.🤖 Generated with Claude Code