Skip to content

Sync with longbridge/gpui-kit 21113cae, gpui-fast 4afc87b - #1

Merged
trancong12102 merged 0 commit into
mainfrom
upstream-sync-2026-10-01
Oct 1, 2026
Merged

trancong12102 merged 0 commit into
mainfrom
upstream-sync-2026-10-01

Conversation

@trancong12102

Copy link
Copy Markdown

Takes longbridge/gpui-kit 201b55a4..21113cae and moves the gpui-fast pin to 4afc87b. This fork carries its commits rebased on upstream, which is also how cargo xtask upstream sync lands it, so this branch is the 33 fork commits rebased onto 21113cae, plus one new commit. Land it by moving main to the branch head (--force-with-lease on b06a0953), not with a merge commit. A merge would bring every fork commit in twice.

Upstream commits taken

Fork commits changed by the rebase

Verification (macOS, at d6e51664)

  • CI's test command, cargo test --workspace --exclude gpui-shell --features gpui-component-story/test-support --locked (example crates excluded as CI does): 2602 passed.
  • --test rendering: 10 passed (Metal).
  • cargo clippy --workspace --exclude gpui-shell --locked -- --deny warnings: clean.
  • cargo xtask upstream sync --only gpui-kit --no-push (Slopty): passes its workspace clippy (--all-targets), the story + recipes tests and the shell tests.

Known flake, already there before this sync

text::window_selection::tests::drag_inside_dialog_still_selects_its_text fails now and then:

  • 1/400 runs at the old gpui-fast pin ca9be59, and 0-9 per 200 at 4afc87b, depending on machine load.
  • Likely cause: GPUI's animation element times itself with Instant::now(), but the test's settle only advances the test executor's clock. The dialog's opening animation can therefore still be moving when the drag lands.

Co-Authored-By: Claude Code

@trancong12102
trancong12102 merged commit d6e5166 into main Oct 1, 2026
trancong12102 added a commit to aislopware/slopty that referenced this pull request Oct 1, 2026
Takes longbridge/gpui-kit #3318 (scroll-table column widths kept, not
measured again), #3281 (rendered ranges of Markdown source, built only when
asked), #3322 (fenced code scrolls inside a height cap), #3338 and #3339,
rebased with our 33 commits (aislopware/gpui-kit#1). gpui-fast moves to
37b6e9a, a formatting merge.

Co-Authored-By: Claude Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant