terminal: Kitty desktop notifications (OSC 99) through the notification effect - #11
Merged
Merged
Conversation
…on effect OSC 99 was parsed and then dropped as unimplemented. The stream now hands it to the handler, which assembles a notification's title and body from its chunks (plain or base64, chunked before or after encoding) and gives the finished one to the desktop_notification effect that OSC 9 and OSC 777 already use, so an embedder that shows those shows these too. The query (p=?) is answered with what is implemented: the title and body payloads, and o=always, which the protocol asks of a terminal that implements no occasions. Close and alive name a notification already shown and are ignored; icons, buttons, sounds, urgency and actions are not implemented and not claimed. Without the effect the sequence is ignored entirely, the query included, so a program falls back. Text is kept to 16 KiB per field, cut on a character. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSC 99 was parsed and then dropped as unimplemented. The stream now hands
it to the handler, which assembles a notification's title and body from
its chunks (plain or base64, chunked before or after encoding) and gives
the finished one to the desktop_notification effect that OSC 9 and
OSC 777 already use, so an embedder that shows those shows these too.
The query (p=?) is answered with what is implemented: the title and body
payloads, and o=always, which the protocol asks of a terminal that
implements no occasions. Close and alive name a notification already
shown and are ignored; icons, buttons, sounds, urgency and actions are
not implemented and not claimed. Without the effect the sequence is
ignored entirely, the query included, so a program falls back.
Text is kept to 16 KiB per field, cut on a character.
Co-Authored-By: Claude Code