Repository navigation
Service: redact database password in startup log, publish sha image tag - #34
Merged
Merged
Conversation
The startup banner printed DATABASE_URL verbatim, including the password. CI now also pushes coverage-service:sha-<commit> so production can pin an immutable tag. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PS44Q7WRmAzMJLhi44dzdo
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Deploying airframes-coverage with
|
| Latest commit: |
408bf58
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70007406.airframes-coverage.pages.dev |
| Branch Preview URL: | https://claude-project-thread-xlxhmp.airframes-coverage.pages.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Kevin · project thread
Summary
Preparation for running the coverage service in production (stack definition is in airframesio/stack).
DATABASE_URLverbatim, password included. It now printspostgres://user:***@host/db. Staging never hit this because it sets no database URL.ghcr.io/airframesio/coverage-service:sha-<commit>, so production can pin an immutable image.:latestis unchanged, so staging keeps working as before.Verification
npm run typecheckandnpm test(14 tests) pass inservice.main, so it is not exercised by this PR's CI.Screenshots
None: a log line and a CI tag, no UI.
Generated by Claude Code
Note
Low Risk
Log redaction and an extra CI image tag only; no auth, data, or runtime behavior changes beyond safer logging.
Overview
Hardens production prep for the coverage service with two small operational changes.
Startup logging no longer prints the full
DATABASE_URL. The banner now masks credentials (e.g.postgres://user:***@host/db) via a regex on the connection string, so passwords don’t appear in logs.Docker publish on
mainstill pushesghcr.io/airframesio/coverage-service:latestand additionally tagssha-${{ github.sha }}, giving deployments an immutable image reference while staging can keep using:latest.Reviewed by Cursor Bugbot for commit 408bf58. Bugbot is set up for automated code reviews on this repo. Configure here.