Skip to content

fix(file-based): override primary_key in PermissionsFileBasedStream to avoid invalid parser-defined key #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ryan Waskewich (rwask) merged 1 commit into from
Feb 11, 2026
Merged

fix(file-based): override primary_key in PermissionsFileBasedStream to avoid invalid parser-defined key #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions airbyte_cdk/sources/file_based/stream/concurrent/adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,7 @@ def get_json_schema(self) -> Mapping[str, Any]:

@property
def primary_key(self) -> PrimaryKeyType:
return (
self._legacy_stream.config.primary_key
or self.get_parser().get_parser_defined_primary_key(self._legacy_stream.config)
)
return self._legacy_stream.primary_key
Comment thread
rwask marked this conversation as resolved.

def get_parser(self) -> FileTypeParser:
return self._legacy_stream.get_parser()
Expand Down
5 changes: 5 additions & 0 deletions airbyte_cdk/sources/file_based/stream/permissions_file_based_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from airbyte_cdk.models import AirbyteLogMessage, AirbyteMessage, Level
from airbyte_cdk.models import Type as MessageType
from airbyte_cdk.sources.file_based.config.file_based_stream_config import PrimaryKeyType
from airbyte_cdk.sources.file_based.file_based_stream_permissions_reader import (
AbstractFileBasedStreamPermissionsReader,
)
Expand Down Expand Up @@ -35,6 +36,10 @@ def __init__(
super().__init__(**kwargs)
self.stream_permissions_reader = stream_permissions_reader

@property
def primary_key(self) -> PrimaryKeyType:
return self.config.primary_key

def _filter_schema_invalid_properties(
self, configured_catalog_json_schema: Dict[str, Any]
) -> Dict[str, Any]:
Expand Down
Loading