Skip to content

feat(standard-tests): assert discovered catalog properties in test_discover #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anatolii Yatsuk (tolik0) merged 4 commits into from
Oct 13, 2026
Merged

feat(standard-tests): assert discovered catalog properties in test_discover #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4924122
feat(standard-tests): assert discovered catalog properties in test_di…
tolik0 Oct 8, 2026
afe20c0
test: parenthesize implicitly concatenated messages in catalog check …
tolik0 Oct 9, 2026
43eab22
fix(standard-tests): honour declared schema draft and anyOf/oneOf typ…
tolik0 Oct 9, 2026
4808b4f
docs(standard-tests): document the discover catalog gate and strict mode
tolik0 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions airbyte_cdk/test/standard_tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,19 @@ class TestSuiteSourcePokeAPI(standard_tests.DeclarativeSourceTestSuite):
- `SourceTestSuiteBase`: A test suite for sources.
- `DestinationTestSuiteBase`: A test suite for destinations.

`SourceTestSuiteBase.test_discover` checks the discovered catalog. Some of these checks are not
enforced yet: their problems are reported as a `DiscoveredCatalogWarning` and do not fail the
test. To make them fail, turn the warning into an error:

```bash
pytest -W error::airbyte_cdk.test.standard_tests.DiscoveredCatalogWarning
airbyte-cdk connector test --pytest-arg=-Werror::airbyte_cdk.test.standard_tests.DiscoveredCatalogWarning
```

'''

from airbyte_cdk.test.models.scenario import ConnectorTestScenario
from airbyte_cdk.test.standard_tests._catalog_checks import DiscoveredCatalogWarning
from airbyte_cdk.test.standard_tests.connector_base import ConnectorTestSuiteBase
from airbyte_cdk.test.standard_tests.declarative_sources import (
DeclarativeSourceTestSuite,
Expand All @@ -40,5 +50,6 @@ class TestSuiteSourcePokeAPI(standard_tests.DeclarativeSourceTestSuite):
"ConnectorTestSuiteBase",
"DeclarativeSourceTestSuite",
"DestinationTestSuiteBase",
"DiscoveredCatalogWarning",
"SourceTestSuiteBase",
]
Loading
Loading