Repository navigation
fix(declarative): seed parent state only from a scalar legacy child cursor value - #1189
Merged
Baz (bazarnov) merged 1 commit intoOct 2, 2026
Merged
Conversation
…ursor value A child state with a single non-cursor value, such as the resumable full refresh sentinel or a legacy per-partition state without parent_state, was re-keyed under the parent's cursor field and crashed the parent cursor initialization with 'No format in [...] matching ...'.
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@bazarnov/fix-parent-state-fallback-scalar-only#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch bazarnov/fix-parent-state-fallback-scalar-onlyPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
PyTest Results (Fast)4 919 tests +6 4 907 ✅ +6 10m 51s ⏱️ -2s Results for commit 966ed49. ± Comparison against base commit f243b0f. This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both. |
PyTest Results (Full)4 922 tests +6 4 910 ✅ +6 15m 56s ⏱️ +6s Results for commit 966ed49. ± Comparison against base commit f243b0f. This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both. |
Baz (bazarnov)
requested review from
Daryna Ishchenko (darynaishchenko) and
Anatolii Yatsuk (tolik0)
September 29, 2026 10:41
Anatolii Yatsuk (tolik0)
approved these changes
Oct 2, 2026
Baz (bazarnov)
deleted the
bazarnov/fix-parent-state-fallback-scalar-only
branch
October 2, 2026 11:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
incremental_dependency: trueand noparent_statein the child state,_instantiate_parent_stream_state_managerre-keys a single child state value under the parent's cursor field. Since #707 it accepts any value, so a child state that is not a cursor value crashes the source at startup withValueError: No format in [...] matching ...:{"__ab_full_refresh_sync_complete": true}, the resumable full refresh sentinel (e.g. a stream migrated from a PythonHttpStream);{"states": [...]}withoutparent_state.#1079 fixed the same crash for
__ab_no_cursor_state_messageonly.Changes
The fallback seeds the parent only from a non-bool
str,intorfloat. Any other value leaves the parent state empty, so the parent starts from its configured start, as it does without state.Tests
The #1079 test is parametrized over 7 child states: the 3 non-cursor shapes (2 fail on
main) and 4 guards (str,intandfloatlegacy values seed the parent; a multi-key state does not). Each clause is mutation-covered.Supersedes #1069 and #1070.