Repository navigation
[PR-verification] fix(low-code): support AsyncRetriever in DynamicSchemaLoader - #1179
Closed
Baz (bazarnov) wants to merge 5 commits into
Closed
Baz (bazarnov) wants to merge 5 commits into
Baz (bazarnov) wants to merge 5 commits into
Conversation
In create_dynamic_schema_loader, the retriever was created with only partition_router but not stream_slicer. This caused AsyncRetriever creation to fail with 'missing required keyword-only argument: stream_slicer' since AsyncRetriever requires stream_slicer as a keyword-only argument while SimpleRetriever accepts partition_router. The fix mirrors the pattern used in create_default_stream, passing both stream_slicer and partition_router when creating the retriever. Resolves #766 Co-Authored-By: bot_apk <apk@cognition.ai>
- AsyncRetriever.read_records drives the jobs through stream_slicer.stream_slices() when called without a slice - DynamicSchemaLoader takes the first Mapping record, skipping the slice log message - Reject an AsyncRetriever with a partition_router in DynamicSchemaLoader: only the first record is read, so extra jobs would be orphaned - Add end-to-end discover tests (JSON and CSV downloads), a guard test and a non-record skip test
…hemaLoader, cover the read path
…, cover an empty download
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@bazarnov/verify-async-dynamic-schema#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch bazarnov/verify-async-dynamic-schemaPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation run for a candidate change. Do not merge, do not review - this PR will be closed after CI completes.