Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(streams): opt-in time-throttle for legacy per-slice state emission #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(streams): opt-in time-throttle for legacy per-slice state emission #1036
Changes from all commits
33b59476e3c5d4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline is failing due to formatting — could you run
poetry run ruff format .to fix this?The ruff format check flagged lines 269-276 as needing reformatting. The logic itself looks solid, wdyt?
🧰 Tools
🪛 GitHub Actions: Linters / 0_Ruff Format Check.txt
[error] 269-279: ruff format --diff reported formatting changes needed (code reformatted to a single-line call). Run 'poetry run ruff format .' to apply formatting.
🪛 GitHub Actions: Linters / Ruff Format Check
[error] 269-276: ruff format --diff reported formatting changes were needed. It would reformat 2 files (this file). Run 'poetry run ruff format .' or use 'ruff format --write' to apply formatting.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline failing on formatting — ruff wants this list comprehension on a single line.
Could you run
poetry run ruff format .to auto-fix this?🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same formatting fix needed here for the list comprehension.
Running
poetry run ruff format .will fix both list comprehensions in these new tests.🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.