Skip to content

fix(cdk): Classify HTTP 400 as config error #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devin-ai-integration wants to merge 2 commits into from
Closed

fix(cdk): Classify HTTP 400 as config error #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b1ac3
fix(cdk): classify HTTP 400 as config error
devin-ai-integration[bot] May 23, 2026
51951c3
test(cdk): update resumable refresh 400 classification
devin-ai-integration[bot] May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
),
400: ErrorResolution(
response_action=ResponseAction.FAIL,
failure_type=FailureType.system_error,
failure_type=FailureType.config_error,
error_message="HTTP Status Code: 400. Error: Bad request. Please check your request parameters.",
),
401: ErrorResolution(
Expand Down
2 changes: 1 addition & 1 deletion unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_default_error_handler_with_default_response_filter(
parameters={},
),
ResponseAction.RETRY,
FailureType.system_error,
FailureType.config_error,
"HTTP Status Code: 400. Error: Bad request. Please check your request parameters.",
),
(
Expand Down
2 changes: 1 addition & 1 deletion unit_tests/sources/mock_server_tests/test_resumable_full_refresh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,6 @@ def test_resumable_full_refresh_failure(self, http_mocker):
page=2
)

assert actual_messages.errors[0].trace.error.failure_type == FailureType.system_error
assert actual_messages.errors[0].trace.error.failure_type == FailureType.config_error
assert actual_messages.errors[0].trace.error.stream_descriptor.name == "justice_songs"
assert "Bad request" in actual_messages.errors[0].trace.error.message
6 changes: 3 additions & 3 deletions unit_tests/sources/streams/http/test_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,13 +785,13 @@ def test_send_request_respects_environment_variables():
@pytest.mark.parametrize(
"response_code, expected_failure_type, error_message, exception_class",
[
(400, FailureType.system_error, "test error message", UserDefinedBackoffException),
(400, FailureType.config_error, "test error message", UserDefinedBackoffException),
(401, FailureType.config_error, "test error message", UserDefinedBackoffException),
(403, FailureType.transient_error, "test error message", UserDefinedBackoffException),
(400, FailureType.system_error, "test error message", DefaultBackoffException),
(400, FailureType.config_error, "test error message", DefaultBackoffException),
(401, FailureType.config_error, "test error message", DefaultBackoffException),
(403, FailureType.transient_error, "test error message", DefaultBackoffException),
(400, FailureType.system_error, "test error message", RateLimitBackoffException),
(400, FailureType.config_error, "test error message", RateLimitBackoffException),
(401, FailureType.config_error, "test error message", RateLimitBackoffException),
(403, FailureType.transient_error, "test error message", RateLimitBackoffException),
],
Expand Down
Loading