Repository navigation
fix: resolve document timestamp type at runtime - #1415
Draft
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Draft
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Conversation
👋 Welcome to PyAirbyte!Thank you for your contribution from Kayvan-Zahiri/PyAirbyte! We're excited to have you in the Airbyte community. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/Kayvan-Zahiri/PyAirbyte.git@codex/fix-document-runtime-type' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/Kayvan-Zahiri/PyAirbyte.git@codex/fix-document-runtime-type'PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesIf you have any questions, feel free to ask in the PR comments or join our community:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructing a
Documentor callingDocumentRenderer.render_document()raisesPydanticUserError: Document is not fully defined, even whenlast_modifiedis omitted. Generating the model's JSON schema fails for the same reason: thedatetimemodule is imported only insideTYPE_CHECKING, so Pydantic cannot resolve the field at runtime.Import
datetimeat runtime, with a targeted TC003 exemption documenting the Pydantic requirement. Add five regressions covering omitted and null timestamps, an ISO timestamp, record rendering, and JSON-schema generation.This bug exists on both
mainandrelease-candidate/v1; the patch targetsmainper AGENTS.md.Validation on Python 3.12 with the release branch's frozen development environment:
No live Airbyte sync, database deployment, or paid service was used. Tests run with telemetry disabled. Full integration and generated-documentation suites are outside this validation.