Repository navigation
Conversation
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Welcome to PyAirbyte!Thank you for your contribution from HootRock/PyAirbyte! We're excited to have you in the Airbyte community. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/HootRock/PyAirbyte.git@fix/hydrate-secret-reference-lists-main' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/HootRock/PyAirbyte.git@fix/hydrate-secret-reference-lists-main'PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesIf you have any questions, feel free to ask in the PR comments or join our community:
|
Configurations such as
{"tokens": ["secret_reference::TOKEN"]}currently retain the reference instead of resolving it. Nested lists are skipped as well, so validation and the configuration passed to a connector can receive unresolved references.Walk dictionary values and list elements with the same recursive logic. This keeps the public dictionary API, copied-input behavior, existing missing-secret errors and
SecretStringmasking. The tests use real environment-backed secret lookup, including nested lists/dictionaries and ordinary values.This addresses the shared-hydration follow-up explicitly noted in #1387; the original secret-reference support was introduced in #696. It targets
mainas a current-release bug fix, following the documented automatic sync intorelease-candidate/v1.Validation on Python 3.12.12 with frozen dependencies:
ConnectorBase.set_config(validate=True)probe: flat/nested lists both fail before the patch and pass after it; the execution configuration resolves them and the caller's input is retained. No live connector or Cloud calls.pyrefly check, andgit diff --check: passed.test_connector_resolution_validates_workspace_scope[connector_in_other_workspace]reaches an unmocked Cloud inspect request on unmodified main too;test_get_time_strexpects UTC but this Windows host uses UTC+8. The full suite is not claimed green.AI-assisted implementation and regression tests with Codex; independently reviewed.
reviewed and tested locally.