Repository navigation
ci: test with torch 2.13 and numpy 1.26 - #9
Merged
Merged
Conversation
|
OX Security reviewed this pull request — nothing to fix.
Branch |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
CI installed torch 2.0.0, which is built against numpy 1, but an unpinned scipy install pulled in numpy 2.2.6. That broke torch and numpy interop and failed 4 tests. - Bump the setup action's default torch version to 2.13.0. - Install pyg-lib 0.8.0 instead of unpinned scipy, since InducedNeighborSampler needs pyg-lib or torch-sparse. - Remove the unused full_install input. - Pin numpy 1.26.4 and scipy 1.10.1 in the test install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maxg0811
force-pushed
the
ci/test-torch-213-numpy-matrix
branch
from
November 16, 2026 10:52
dc4c06b to
5bd5342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Test workflow fails on main (run). The setup action installed torch 2.0.0, which is built against numpy 1. The unpinned
pip install scipythen pulled in numpy 2.2.6, which broke torch and numpy interop (Failed to initialize NumPy: _ARRAY_API not found). 4 tests failed withNumpy is not availableandCould not infer dtype of numpy.float32.Changes
pyg-lib==0.8.0.InducedNeighborSamplerneeds pyg-lib or torch-sparse.full_installinput.Testing
Local run on Python 3.10 with torch 2.13.0, numpy 1.26.4, scipy 1.10.1 and pyg-lib: 9 passed, 1 skipped. Without pyg-lib, the sampler test fails, which is why the install stays.
🤖 Generated with Claude Code