Repository navigation
Conversation
|
OX Security reviewed this pull request — nothing to fix.
Branch |
Author
|
Closing: this fork uses no Codecov token or other secret (codecov-action@v3 without a token), and its Test workflow is disabled (disabled_fork), so the change would never run. Not needed for removing the org secret CODECOV_TOKEN (OP-3890). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OP-3890: the org secret
CODECOV_TOKENis not rotated. Instead, every repo uploads to Codecov with OIDC, and then the token is deleted. aignostics/peng-dev-random#255 proved that an OIDC upload works for this org. Reference: aignostics/pdd-mapper#89.How
test.yamlalready passed no token. The upload step usedcodecov/codecov-action@v3, a tag that runs on a removed Node runtime. It now uses the v7.1.1 commit pin withuse_oidc: true.testjob gets apermissionsblock:contents: readandid-token: write. Before, it had none and used the repo default. This is narrower than the default.actions.lock, no docs that name the token.After all repos in OP-3890 merge, the org secret
CODECOV_TOKENis deleted.Verified
git grep -i codecov_tokenreturns nothing.pinact run --checkontest.yamlpasses for the changed step. It still lists theactions/checkout@v4andactions/setup-python@v5tags, which this change does not touch.--offline --persona pedantic): every finding on the changed lines is gone, and no new finding.Testworkflow asdisabled_fork, so it does not run on the PR.Not verified
cron: 0 5 1,15 * *) does not run on a PR.Testworkflow runs after the merge, if it is enabled.Build / packagefails because the org policy requires SHA pins andBuildusesactions/checkout@v4. It also fails onmainand is not part of this change.SKIP=black,flake8,isort. The change has no Python file.