Repository navigation
Conversation
|
OX Security reviewed this pull request — nothing to fix.
Branch |
idelsink
marked this pull request as ready for review
November 12, 2026 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Our org requires every action to be pinned to a full commit SHA. That rule also covers the actions that other actions use inside them. We do not control those inner pins. The lockfile records the SHA of every action, also the inner ones, and GitHub accepts it as SHA pinning.
We will soon turn on the org-wide GitHub policy "Require lockfile". After that, a workflow that is not in this lockfile cannot run. Please keep
actions.lockup to date when you change a workflow. Docs: https://docs.github.com/en/actions/concepts/security/workflow-dependency-lockfilesHow
.github/workflows/actions.lock(github/gh-actions-lock v0.4.1).uses: ./.github/actions/setuptouses: $/.github/actions/setupintest.yaml.$/is the GitHub syntax for an action in the same repo at the running commit.pypa/gh-action-pypi-publish@release/v1(lockfile commit 7245906).Verified
gh actions-lock --verifypasses locally.Not verified
./.github/.tmp/.generated-actions/run-pypi-publish-in-docker-container). The lockfile does not cover it (gh-actions-lock troubleshooting, "local action").$/step did not run in CI.Check before merge
--no-verify. The team must fix the hook, not this PR. The change has no Python files.