Skip to content

ci(actions): add workflow dependency lockfile - #7

Open
idelsink wants to merge 1 commit into
mainfrom
ci/actions-lock
Open

idelsink wants to merge 1 commit into
mainfrom
ci/actions-lock

Conversation

@idelsink

@idelsink idelsink commented Nov 12, 2026 •

Copy link
Copy Markdown

Why

Our org requires every action to be pinned to a full commit SHA. That rule also covers the actions that other actions use inside them. We do not control those inner pins. The lockfile records the SHA of every action, also the inner ones, and GitHub accepts it as SHA pinning.

We will soon turn on the org-wide GitHub policy "Require lockfile". After that, a workflow that is not in this lockfile cannot run. Please keep actions.lock up to date when you change a workflow. Docs: https://docs.github.com/en/actions/concepts/security/workflow-dependency-lockfiles

How

  • Adds .github/workflows/actions.lock (github/gh-actions-lock v0.4.1).
  • Changes one step from uses: ./.github/actions/setup to uses: $/.github/actions/setup in test.yaml. $/ is the GitHub syntax for an action in the same repo at the running commit.
  • The tool also pinned the branch ref pypa/gh-action-pypi-publish@release/v1 (lockfile commit 7245906).

Verified

  • This repo is public, so the org lint check does not run here. gh actions-lock --verify passes locally.

Not verified

  • Warning, no action needed: the tool cannot follow one workspace-local action inside pypa's action (./.github/.tmp/.generated-actions/run-pypi-publish-in-docker-container). The lockfile does not cover it (gh-actions-lock troubleshooting, "local action").
  • The Test workflow is disabled in this repo (it was disabled on the fork), so the $/ step did not run in CI.

Check before merge

  • The repo's pre-commit hook fails to install isort 5.10.1 ("Poetry configuration is invalid"). The owner made the commit with --no-verify. The team must fix the hook, not this PR. The change has no Python files.

@idelsink idelsink added the 🤖 stage: agent working Owner: agent. Agents build, verify and review this PR. Agents may push and edit. label Nov 12, 2026
@ox-security

ox-security Bot commented Nov 12, 2026

Copy link
Copy Markdown

OX Security Logo

OX Security reviewed this pull request — nothing to fix.

✔ No issues found

Branch ci/actions-lock → main

View scan in OX Security →

@idelsink idelsink added 👀 stage: agent review Owner: agent. A fresh AI reviewer checks this PR. Only that reviewer pushes. and removed 🤖 stage: agent working Owner: agent. Agents build, verify and review this PR. Agents may push and edit. 👀 stage: agent review Owner: agent. A fresh AI reviewer checks this PR. Only that reviewer pushes. labels Nov 12, 2026
@idelsink
idelsink marked this pull request as ready for review November 12, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

Couldn't load assignees.