fix: expand chat model detection to cover 34 model families (fixes #7)#25
Open
z3r0-815 wants to merge 1 commit into
Open
fix: expand chat model detection to cover 34 model families (fixes #7)#25z3r0-815 wants to merge 1 commit into
z3r0-815 wants to merge 1 commit into
Conversation
Fixes agustif#7 - Missing nemotron and glm in categorizeModel() - Add 26 missing chat model families to categorizeModel(): nemotron, glm, deepseek, gemini, mixtral, command, dbrx, olmo, starcoder, granite, aya, baichuan, bloom, codestral, dolphin, hermes, internlm, jamba, mpt, nous, openchat, replit, solar, vicuna, wizardlm, yi, zephyr - Add 81 comprehensive unit tests in test/utils/categorize-model.test.ts - All 97 tests passing (16 existing + 81 new) - TypeScript strict mode clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7 —
categorizeModel()was missingnemotron(NVIDIA) andglm(Zhipu AI) from its chat model family list. Expanded the detection to cover 34 model families in total, comprehensively matching LM Studio's actual model ecosystem.Changes
src/utils/index.tscategorizeModel()check:nemotron,glmdeepseek,gemini,mixtral,command,dbrx,olmo,starcoder,granite,aya,baichuan,bloom,codestral,dolphin,hermes,internlm,jamba,mpt,nous,openchat,replit,solar,vicuna,wizardlm,yi,zephyrlowerId.includes()pattern as the original codetest/utils/categorize-model.test.ts(new file)Verification
tsc --noEmit(strict mode)vitest runNote:
npm run validatefails due to a pre-existing missing ESLint config file, not related to this change.Risk Assessment
||OR chain. Original families unchanged.embed/embeddingcheck runs first, so no chat family can hijack an embedding model.yi,aya,mpt) are distinctive enough in practice.commandis intentionally broad to catch Cohere Command-R models — benign false positives just get the safe default chat metadata.