Repository navigation
Rename a column named registry, like metadata already was - #491
Merged
sheinbergon merged 2 commits intoNov 18, 2026
Merged
Conversation
sheinbergon
approved these changes
Nov 17, 2026
Collaborator
|
@abhishekcpp007, please bind dependency versions with <2.1 so we can merge this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemy reserves both
metadataandregistryon a declarative class and warns about either one (orm/decl_base.py, thek == "registry" or ...branch).find_free_nameonly renamesmetadata, so a table with aregistrycolumn generates code that warns as soon as it is imported:Reproduced with sqlacodegen 4.0.4 against
CREATE TABLE collide (id INTEGER PRIMARY KEY, metadata TEXT, registry TEXT)on SQLite: themetadatacolumn came out asmetadata_, theregistryone came out asregistry.One word change plus a test that mirrors
test_metadata_column. Verified in Docker on 3.12: master 12 failed 151 passed, branch 12 failed 152 passed, and the twelve failures are the same postgres ones on both.Disclaimer: I used an LLM while working on this.