Repository navigation
Add SQLAlchemy 2.1 support #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Claire-ovo
wants to merge
12
commits into
agronholm:master
Choose a base branch
from
Claire-ovo:fix/nested-type-arguments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0e7848e
Fix rendering and imports of nested type arguments
Claire-ovo b1ba7cd
Preserve named type metadata and test SQLAlchemy 2.1 output
Claire-ovo 62ac56f
Separate SQLAlchemy compatibility and test both minor versions
Claire-ovo cfa486d
Reword changelog entry for SQLAlchemy 2.1 support and link PR #489
sheinbergon 05f90bf
Remove sub python 3.10 tests new tests
sheinbergon 1cba8c6
Remove the standalone domain metadata test
sheinbergon ad630f7
Drop the SQLAlchemy < 2.1 upper bound
sheinbergon f992ad9
Stop rendering schema and metadata for named types on SQLAlchemy 2.1
sheinbergon 332f05a
Move the SQLAlchemy 2.1 changelog entry and credit the rework
sheinbergon a6a97ed
Wrap the SQLAlchemy 2.1 changelog entry
sheinbergon b6aedeb
Merge branch 'master' into fix/nested-type-arguments
sheinbergon 9b7d0a7
Moved the changelog entry
agronholm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,16 @@ on: | |
|
|
||
| jobs: | ||
| test: | ||
| name: Python ${{ matrix.python-version }} / SQLAlchemy ${{ matrix.sqlalchemy }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| sqlalchemy: [">=2.0.29,<2.1", ">=2.1,<2.2"] | ||
| exclude: | ||
| # SQLAlchemy 2.1 requires Python 3.11 or later. | ||
| - python-version: "3.10" | ||
| sqlalchemy: ">=2.1,<2.2" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
@@ -22,7 +28,9 @@ jobs: | |
| cache: pip | ||
| cache-dependency-path: pyproject.toml | ||
| - name: Install dependencies | ||
| run: pip install --group test -e .[sqlmodel,citext,geoalchemy2,pgvector] | ||
| run: pip install --group test -e .[sqlmodel,citext,geoalchemy2,pgvector] "SQLAlchemy${{ matrix.sqlalchemy }}" | ||
| - name: Show dependency version | ||
| run: python -c "import sqlalchemy; print(sqlalchemy.__version__)" | ||
|
Comment on lines
+32
to
+33
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do we need this for? The previous step already shows clearly which version is installed. |
||
| - name: Test with pytest | ||
| run: coverage run -m pytest | ||
| - name: Upload Coverage | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives us 9 CI jobs. Do we need all of them? We could just add the SQLA 2.0 jobs as inclusions (instructions here).