Repository navigation
Conversation
Signed-off-by: Srinivasa Dinakar Jainti <dinakarjs@gmail.com>
Signed-off-by: Srinivasa Dinakar Jainti <dinakarjs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Stacked follow-up to #533 at 0555c4c, addressing lywinged's entry-parser fuzz coverage finding. The base deliberately remains #533's branch; this PR must not bypass its 14 November governance hold. Retarget/rebase onto main after #533 is accepted. It changes only the fuzz callback and its deterministic tests, not normative semantics.
Half the callback paths now vary the registry entry; each receipt/entry lane has raw-JSON and structured-mutation paths. The entry is fed directly to parse_entry and to tr_anc.check, and a reported pass is independently replayed against that supplied entry. Added controls cover every missing required field, non-string timestamp/producer/batch_id values, a valid twin, all five mutation branches, direct non-object parser coverage, fixture preservation and a false-pass oracle.
Validation: all checkout blobs were verified against 0555c4c before editing. Python 3.12.14 in an existing environment: 83 focused entry-binding/inclusion/harness tests pass; 34 are harness tests. Ruff passes. The initial environment lacked click; the final selection used an existing environment with click and explicit checkout PYTHONPATH. No real Atheris campaign or full supported-Python matrix was executed; deterministic tests replace instrumentation/byte selection but use the real parser/checker/callback.
Test that fails with the change switched off
Disabling the entry lane causes 29 harness failures; substituting the fixed entry into the checker causes 26 failures in the earlier 33-test selection. Removing the direct parse_entry call initially survived because the pass oracle masked it; the added non-object control now fails specifically when that call is removed. Final restored selection: 83 pass. The valid twin and existing receipt-oracle controls remain.
Review and scope
No new cold-reader review claimed. Author/maintainer review and hosted validation remain. Source: #533's current parse_entry contract and lywinged's review at #533 (review). No change to entry authenticity assumptions, conformance levels or comment-period dates. Prepared with Codex.
DCO
Signed-off-by: Srinivasa Dinakar Jainti dinakarjs@gmail.com