Repository navigation
Conversation
Signed-off-by: Raghuvar Karthik Durga <177662415+drk-ram@users.noreply.github.com>
Contributor
|
🔴 Contributor Check: HIGH
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:HIGH
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enforce delegation credential validity windows (
iat,nbf,exp) and non-decreasing hop timestamps (iat) against parent hops insidecross_check_trace_dag(ca2a verify-lineage).Why
cross_check_trace_dagchecked hop signatures, subject/issuer continuity, and scope attenuation, but never compared a hop record'siatagainst the matched delegation credential's[nbf, exp]validity window or the parent hop'siat. As a result, hop records signed after credential expiry, beforenbf/iat, or backdated before their parent hop were reported asauthenticated_lineage.Closes #306
Security impact
Prevents expired, premature, or backdated hop records from passing
cross_check_trace_dagandca2a verify-lineageasauthenticated_lineage.Test plan
pytestpasses (pytest tests/unit/test_trace_binding.py tests/unit/test_lineage_cli.py— 71 passed)ruff checkpasses (ruff check src tests— passed)mypypasses (mypy src— passed)DCO sign-off
Signed-off-by:(git commit -s)