refactor: introduce CredentialRepository and ProviderRepository to ce…#347
Merged
Conversation
…ntralize storage and management logic; move functions into their respective domains
… parameter from route dependencies
manojbajaj95
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to centralize storage and management logic; move functions into their respective domains
Description
Refactored the authsome server boundary so
identity,vault, andauthremain more orthogonal, with server code coordinating them.Key changes:
CredentialRepository.ProviderRepository.credential_repository.py.auth.utils.server.schemas.Motivation and Context
AuthServicehad accumulated too many responsibilities: provider loading, vault key construction, credential persistence, auth flow orchestration, and server policy behavior. This refactor narrows its role to orchestration while keeping storage and provider management in server-owned repositories.This makes the module boundaries cleaner and prepares
auth,identity, andvaultto remain reusable independently.How Has This Been Tested?
Tested with:
Result: all tests passed, including the full suite of
361tests.Types of changes
Checklist: