Fix Linux-only failure in register_flow perms test (stat portability) - #24
Merged
Merged
Conversation
register_flow "correct permissions" used `stat -f '%Lp' || stat -c '%a'`. On Linux `stat -f` prints filesystem status and exits 0, so the BSD-first form never falls through to the GNU form and the assert compared garbage instead of the mode — the test failed on the Linux CI runner (the code's chmod 600 is correct). Try GNU `stat -c` first, BSD `stat -f` as the macOS fallback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
register_flow: registration file has correct permissionstest failed on the Linux CI runner (surfaced the first time CI ran, after #16). Root cause is the test, not the code: it usedstat -f '%Lp' || stat -c '%a'. On Linux,stat -fprints filesystem status and exits 0, so the BSD-first form never reaches the GNU fallback and the assert compared garbage. The code'schmod 600on the registration file is correct. Reversed to GNUstat -cfirst, BSDstat -ffallback — verified 600 on both macOS and Linux.🤖 Generated with Claude Code