Skip to content

fix(daemon): name a Google Chat DM row after the person in it - #2589

Merged
zfy0701 merged 1 commit into
mainfrom
claude/googlechat-dm-row-name
Sep 27, 2026
Merged

zfy0701 merged 1 commit into
mainfrom
claude/googlechat-dm-row-name

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

What changed

Found in the docs/designs/google-chat-integration.md §9 end-to-end pass: after a direct message reached the agent, the console's DIRECT MESSAGES row showed the raw space id instead of the person. A DM space carries no display name, and the daemon's read port answered getChannelInfo for a DM with no name, so the name resolver had nothing to cache.

  • packages/daemon/src/platforms/googlechat/connection.ts: for a DIRECT_MESSAGE space, getChannelInfo reads the space's human memberships (spaces.members.list with member.type = "HUMAN", page size 2), which app authentication allows (only Chat app memberships are excluded, verified live), and names the row after the single human member. A failed read or more than one person leaves the row on its id. Spaces are unchanged.
  • Tests: the read-port test now covers the DM name and the filter, and a new case pins the two fallbacks (refused read, two people).
  • Docs: §5 records where a DM row's name comes from.

Verification

  • pnpm --filter @agentconnect.md/daemon typecheck: pass.
  • googlechat-connection, googlechat-ingress: pass.
  • eslint and prettier on the touched files: clean.

Created by Claude Code · Fable 5.1.

🤖 Generated with Claude Code · Fable 5.1

A DM space carries no display name, so the console showed the raw space
id for a direct conversation. App authentication may list a space's human
memberships (only Chat apps are excluded), so the read port now answers a
DM's name from its single human membership and leaves the row on its id
when the read fails or finds more than one person. Spaces are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@zfy0701
zfy0701 enabled auto-merge (squash) September 27, 2026 08:53

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The Google Chat DM read port now derives the row name from its single human membership and preserves the space ID when the membership read fails or is ambiguous. The existing channel-name resolver applies the DM marker and caches that name. The changed tests cover the successful lookup and both fallbacks; git diff --check is clean. I found no blocking issue.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 merged commit 7fe46ca into main Sep 27, 2026
14 checks passed
@zfy0701
zfy0701 deleted the claude/googlechat-dm-row-name branch September 27, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant