fix(daemon): name a Google Chat DM row after the person in it - #2589
Merged
Merged
Conversation
A DM space carries no display name, so the console showed the raw space id for a direct conversation. App authentication may list a space's human memberships (only Chat apps are excluded), so the read port now answers a DM's name from its single human membership and leaves the row on its id when the read fails or finds more than one person. Spaces are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 27, 2026 08:53
Contributor
There was a problem hiding this comment.
Approved. The Google Chat DM read port now derives the row name from its single human membership and preserves the space ID when the membership read fails or is ambiguous. The existing channel-name resolver applies the DM marker and caches that name. The changed tests cover the successful lookup and both fallbacks; git diff --check is clean. I found no blocking issue.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Found in the
docs/designs/google-chat-integration.md§9 end-to-end pass: after a direct message reached the agent, the console's DIRECT MESSAGES row showed the raw space id instead of the person. A DM space carries no display name, and the daemon's read port answeredgetChannelInfofor a DM with no name, so the name resolver had nothing to cache.packages/daemon/src/platforms/googlechat/connection.ts: for aDIRECT_MESSAGEspace,getChannelInforeads the space's human memberships (spaces.members.listwithmember.type = "HUMAN", page size 2), which app authentication allows (only Chat app memberships are excluded, verified live), and names the row after the single human member. A failed read or more than one person leaves the row on its id. Spaces are unchanged.Verification
pnpm --filter @agentconnect.md/daemon typecheck: pass.googlechat-connection,googlechat-ingress: pass.Created by Claude Code · Fable 5.1.
🤖 Generated with Claude Code · Fable 5.1