fix(daemon): register a verified runtime-memory policy for DeepSeek Harness - #2587
Merged
Merged
Conversation
…arness An agent on dsh-acp could not use the `none` memory provider: the runtime had no entry in the runtime-memory registry, so the launch failed closed with "off-switch unverified". dsh-acp is also the default pool preset runtime, so every preset agent hit it. The pinned adapter (@openma/deepseek-harness-acp 0.4.33, vendored dsh 0.1.5-rc.1) has no automatic cross-session memory: memory MCP servers and session references are opt-in overlays, and session query is off and in-memory. Register it as a verified no-op, like kiro-cli. `native` stays unsupported because $DSH_HOME also holds credentials, presets and settings. Add a dsh profile to the ACP matrix so the classification is part of the runtime-memory contract test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 27, 2026 08:13
Contributor
There was a problem hiding this comment.
Approved. The dsh-acp policy enables none for the reviewed 0.4.33 default composition, where cross-session memory is not mounted, while keeping native unsupported. The new ACP matrix profile records that provider contract. I found no blocking issue in the verified merge. git diff --check passed; I could not rerun Vitest locally because this checkout has no installed dependencies. Recheck the no-op classification when the adapter version changes.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting the
nonememory provider for an agent ondsh-acp(DeepSeek Harness) failed at launch withnone memory is not supported for this runtime (off-switch unverified): dsh-acp. The runtime was never classified in the runtime-memory registry, and it is also the default pool preset runtime, so every preset agent that pickednonehit this.dsh-acpinRUNTIME_MEMORY_POLICIESas a verified no-op (same classification askiro-cli).dshprofile to the ACP matrix so the runtime-memory contract test covers it.Why a no-op is correct
Checked against the pinned adapter,
@openma/deepseek-harness-acp@0.4.33, whose vendored runtime is dsh0.1.5-rc.1:config/examples/, never part of a default profile.dsh-session-reference(cross-session context) is not mounted bydsh-base, the ACP app, or the preset.session-query-sqliteispath: ':memory:',openAt: never.nativestays unsupported:$DSH_HOMEalso owns credentials, presets and settings, so redirecting it needs its own isolation design (same reasoning as Grok).The classification holds for this adapter version; a bump of
DEEPSEEK_HARNESS_ACP_VERSIONshould re-check the default profile.Matrix profile
The
scenario/capsare taken from the adapter'sinitializeandconfigOptions:loadSession, http-only MCP, image prompts (the base mountsattachment-local), a sandbox-mode selector (read-only/workspace-write/danger-full-access), model and reasoning-effort selectors, prompt usage, and theuniversalskills identity from the curated catalog.Test plan
vitest run test/acp-matrix/runtime-memory-contract.test.ts test/memory-provider-dispatch.test.ts test/runtime-launch.test.ts test/evaluation-permission.test.ts(105 passed)typecheck, eslint, prettier🤖 Generated with Claude Code · Claude Opus 5.5