Skip to content

fix(chart): route /googlechat/events to the relay pool - #2586

Merged
zfy0701 merged 1 commit into
mainfrom
claude/chart-googlechat-route
Sep 27, 2026
Merged

zfy0701 merged 1 commit into
mainfrom
claude/chart-googlechat-route

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

What changed

The relay serves Google Chat interaction events at /googlechat/events (#2576), but the chart's relay HTTPRoute lists every public relay path explicitly, so the gateway answered 404 before a callback reached the relay. Found while preparing the end-to-end pass of docs/designs/google-chat-integration.md §9: a POST to the path on a deployment running rc.196 returns 404 at the edge.

  • charts/agentconnect/templates/httproute.yaml: the path in the relay rule and in the comment block that documents the relay host's public paths.
  • scripts/test-chart-render.rb: the render contract that guards the list.
  • docs/designs/google-chat-integration.md §2: one sentence noting that the chart's relay route must carry the path, as it does for every other relay ingress.

Same shape as #2582 (/ai-sdk/chat).

Verification

  • helm lint charts/agentconnect: pass.
  • ruby scripts/test-chart-render.rb: chart render contract: ok.

Created by Claude Code · Fable 5.1.

🤖 Generated with Claude Code · Fable 5.1

The relay serves Google Chat interaction events at /googlechat/events
(#2576), but the chart's relay HTTPRoute lists every public relay path
explicitly, so the gateway answered 404 before a callback reached the
relay. Add the prefix to the route and to the render contract that guards
the list.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@zfy0701
zfy0701 enabled auto-merge (squash) September 27, 2026 08:05

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The chart forwards /googlechat/events to the relay pool, matching the relay’s POST route and the Setup Server callback path. The render contract now checks for that route. I found no blocking issue. Helm and Ruby were unavailable in this review environment, so I could not rerun the chart checks reported in the PR.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 merged commit 42fd719 into main Sep 27, 2026
14 checks passed
@zfy0701
zfy0701 deleted the claude/chart-googlechat-route branch September 27, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant