fix(chart): route /googlechat/events to the relay pool - #2586
Merged
Merged
Conversation
The relay serves Google Chat interaction events at /googlechat/events (#2576), but the chart's relay HTTPRoute lists every public relay path explicitly, so the gateway answered 404 before a callback reached the relay. Add the prefix to the route and to the render contract that guards the list. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 27, 2026 08:05
Contributor
There was a problem hiding this comment.
Approved. The chart forwards /googlechat/events to the relay pool, matching the relay’s POST route and the Setup Server callback path. The render contract now checks for that route. I found no blocking issue. Helm and Ruby were unavailable in this review environment, so I could not rerun the chart checks reported in the PR.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The relay serves Google Chat interaction events at
/googlechat/events(#2576), but the chart's relayHTTPRoutelists every public relay path explicitly, so the gateway answered 404 before a callback reached the relay. Found while preparing the end-to-end pass ofdocs/designs/google-chat-integration.md§9: aPOSTto the path on a deployment runningrc.196returns 404 at the edge.charts/agentconnect/templates/httproute.yaml: the path in the relay rule and in the comment block that documents the relay host's public paths.scripts/test-chart-render.rb: the render contract that guards the list.docs/designs/google-chat-integration.md§2: one sentence noting that the chart's relay route must carry the path, as it does for every other relay ingress.Same shape as #2582 (
/ai-sdk/chat).Verification
helm lint charts/agentconnect: pass.ruby scripts/test-chart-render.rb:chart render contract: ok.Created by Claude Code · Fable 5.1.
🤖 Generated with Claude Code · Fable 5.1