Add session/setTitle method#1199
Open
daniel-agentee wants to merge 1 commit into
Open
Conversation
This was referenced May 14, 2026
a8a6ab5 to
b9739d6
Compare
Contributor
|
@benbrandt @anna239, I believe it makes sense to decide on that PR on the next meeting |
b9739d6 to
aa232d5
Compare
Author
|
Rebased onto current @codex review |
aa232d5 to
df5ce77
Compare
Author
|
Updated the branch to include @codex review |
daniel-agentee
added a commit
to daniel-agentee/rust-sdk
that referenced
this pull request
Jun 2, 2026
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
daniel-agentee
added a commit
to daniel-agentee/rust-sdk
that referenced
this pull request
Jun 2, 2026
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
daniel-agentee
added a commit
to daniel-agentee/rust-sdk
that referenced
this pull request
Jun 2, 2026
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
session/setTitleto the Agent Client Protocol, giving clients a standard way to ask an agent to rename an existing session.Title is plain UTF-8. Empty string remains valid at the protocol level so agents can decide whether that means "clear", "reset", or "use an empty title".
Why
Zed's first-party agent can already rename sessions, but ACP-backed sessions cannot, because there is no protocol method for the client to push a new title to the agent. The user-visible symptom is that the title editor in the agent panel appears for ACP threads but the rename cannot be persisted.
SessionInfoUpdatealready exists in the reverse direction (agent -> client) and carriestitle-- this PR adds the missing client -> agent half of the round-trip.How
SetSessionTitleRequestandSetSessionTitleResponseto the generated v1 and v2 agent schemas.SESSION_SET_TITLE_METHOD_NAME = "session/setTitle"to the generated metadata.session/set_modevariants non-convertible to v2.SetSessionTitle.Tests
npm run checkcovers clippy with all features, Prettier/cargo formatting checks, spellcheck, all-feature unit tests, generated-bin tests, and doctests.Companion PRs
Companion codex-acp PRs:
session/setTitleand emitSessionInfoUpdate./rename <new title>as an ACP-client-friendly shortcut.