Add goimports to .golangci.yaml and fix lint errors

[Troy Chiu (troychiu)]

Add goimports to .golangci.yaml to follow Go import organization best practice and fix corresponding lint error.

[Arnaud M. (ameukam)]

LGTM
cc Benjamin Elder (@BenTheElder) Julian Gutierrez Oschmann (@juli4n)

[Benjamin Elder (BenTheElder)]

Lint errors that require manually fixing but are in fact auto-formatted are ... pretty annoying, it just forces people to manually do what could've been automated.

Can we consider goimports in the gofmt flow instead?

cc Tim Hockin (@thockin)

[Troy Chiu (troychiu)]

Lint errors that require manually fixing but are in fact auto-formatted are ... pretty annoying, it just forces people to manually do what could've been automated.

I'm not sure if I fully understood your point, but using golangci-lint run --fix formats them automatically.

[Benjamin Elder (BenTheElder)]

I'm not sure if I fully understood your point, but using golangci-lint run --fix formats them automatically.

Hmm, does that change anything else?

We have make update which does gofmt etc. I'd want it to happen when I call this, but it also seems semi-redundant to gofmt (can we dedupe?)

[Tim Hockin (thockin)]

There was a reason I did gofmt and not goimports, but I can't recall it.

I do not like the idea of --fix being the norm because I have frequently disagreed with the linters.

Is the goimports linters JUST imports or is it all of gofmt, too.

The advantage of update/gofmt.sh is that it does exactly one thing. I don't care if that calls goimports instead (modulo the thing I can't remember)