Skip to content

Fix make with LDFLAGS #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tim Hockin (thockin) wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −10
Open

Fix make with LDFLAGS #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,8 @@ ATECTL := $(BINDIR)/kubectl-ate
# Version stamping. Override on the make command line to pin
# (e.g. `make VERSION=v0.5.0 build`).
VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo dev)
COMMIT ?= $(shell git rev-parse HEAD 2>/dev/null || echo unknown)
BUILD_DATE ?= $(shell date -u +%Y-%m-%dT%H:%M:%SZ)
VERSION_PKG := github.com/agent-substrate/substrate/internal/version
LDFLAGS := -X $(VERSION_PKG).Version=$(VERSION) \
-X $(VERSION_PKG).Commit=$(COMMIT) \
-X $(VERSION_PKG).BuildDate=$(BUILD_DATE)
LDFLAGS := -X=$(VERSION_PKG).Version=$(VERSION)

.PHONY: all
all: build
Expand All @@ -44,10 +40,12 @@ build: build-images build-atectl

.PHONY: build-images
build-images:
$(KO) build --ldflags "$(LDFLAGS)" ./cmd/ateapi
$(KO) build --ldflags "$(LDFLAGS)" ./cmd/atelet
$(KO) build --ldflags "$(LDFLAGS)" ./cmd/podcertcontroller
$(KO) build --ldflags "$(LDFLAGS)" ./cmd/atenet
GOFLAGS='"-ldflags=$(LDFLAGS)"' \
$(KO) build \
./cmd/ateapi \
./cmd/atelet \
./cmd/podcertcontroller \
./cmd/atenet

.PHONY: build-atectl
build-atectl:
Expand All @@ -59,7 +57,8 @@ build-atenet:

.PHONY: build-demos
build-demos:
$(KO) build --ldflags "$(LDFLAGS)" ./demos/counter
GOFLAGS='"-ldflags=$(LDFLAGS)"' \
$(KO) build ./demos/counter

.PHONY: test
test:
Expand Down
Loading