Repository navigation
Ship Windows binaries in releases - #105
Merged
Merged
Conversation
Every recent platform report (#63, #101, #102, #103) came from a Windows user building from source, and Windows has been in the CI matrix for some time. Add windows to the release targets for amd64 and arm64, as zip archives, which is what Windows users expect to unpack. CGO is already off, so this is a cross-compile; a local snapshot release produced working PE executables for both. Document the release archives in the README install section, and ignore GoReleaser's dist/ output so a local snapshot build does not show up as untracked files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Releases shipped only macOS and Linux archives. Every recent platform report (#63, #101, #102, #103) came from a Windows user building from source, and Windows has been in the CI test matrix for some time, so the project already supports the platform without publishing a binary for it.
What changed
.goreleaser.yamladdswindowsto the build targets, for amd64 and arm64, and packages Windows builds as.zipwhile macOS and Linux stay.tar.gz. The archiveformatkey is moved to the currentformatsform, which the override needs. CGO was already off, so this is a plain cross-compile. The Homebrew tap is unaffected..exename on Windows..gitignoreignores GoReleaser'sdist/so a local snapshot build does not leave untracked files.Verification
goreleaser release --snapshot --clean --skip=publish,homebrewbuilt all six targets and producedskill-validator_<version>_windows_amd64.zipand_windows_arm64.zip, each containingskill-validator.exe, README, and LICENSE.fileconfirms the arm64 binary is a PE32+ Aarch64 console executable.goreleaser checkstill reports the pre-existingbrewsdeprecation, which is unrelated to this change and left alone.No CHANGELOG entry, following the release-commit pattern.