Skip to content

Remove obb-collider component when removing grabbable - #5859

Open
mrxz wants to merge 1 commit into
aframevr:masterfrom
mrxz:grabbable-remove-obb-collider
Open

mrxz wants to merge 1 commit into
aframevr:masterfrom
mrxz:grabbable-remove-obb-collider

Conversation

@mrxz

@mrxz mrxz commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #5857

Description:
The grabbable component automatically adds the obb-collider component to the entity. Upon removal of the grabbable component, the obb-collider remained. This PR adds removal logic such that the grabbable cleans up after itself and also removes the obb-collider.

Changes proposed:

  • Let grabbable also remove obb-collider component
  • Fix race conditions in grabbable component where event listeners would trigger after the component was already removed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing grabbable does not remove obb-collider

1 participant