Skip to content

Fix channel NyxID credential routing - #3690

Merged
louis4li merged 3 commits into
feature/integratefrom
fix/2026-10-01_channel-nyxid-credential-routing
Oct 1, 2026
Merged

louis4li merged 3 commits into
feature/integratefrom
fix/2026-10-01_channel-nyxid-credential-routing

Conversation

@louis4li

@louis4li louis4li commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep registration AgentKey authority for merchant-owned channel inventory, skill loading, and operation execution even when sender binding exists.
  • Use client credentials only for recommended skill ref ensure/provisioning in registration AgentKey mode.
  • Include the target NyxID service in connected-service invocation visibility failures so users know which service permission to add.

Test plan

  • dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --filter FullyQualifiedName~ChannelNyxIdConnectedServiceInventoryToolSourceTests
  • bash tools/ci/test_stability_guards.sh
  • Local relay smoke: registration revision 147 included aevatar-local-tunnel; nyxid_invoke_operation no longer returned operation_not_visible and the LLM completed with finish=stop.

🤖 Generated with Claude Code

Keep registration AgentKey authority for merchant-owned channel operations while using client credentials only for recommended skill ref handling, and surface the target service when connected-service invocation is not visible.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li requested a review from jason-aelf as a code owner October 1, 2026 03:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T03:57:50.515034Z 4572efd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4572efd639

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agents/Aevatar.GAgents.NyxidChat/AgentRunReplyGenerationExecutor.cs
louis4li and others added 2 commits October 1, 2026 15:38
Use sender-bound bearer credentials for connected-service operations while preserving registration AgentKey access for default skill loading and generated skill refs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent delayed invalid_grant reconciliation for an old binding from clearing a newer replacement binding while preserving explicit unbind behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li merged commit 014fb68 into feature/integrate Oct 1, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant