Skip to content

[CLIENT-681] Fix bug where only up to 4096 bytearray objects can be used in one client command - #779

Open
DomPeliniAerospike wants to merge 273 commits into
v20from
CLIENT-681-2025
Open

DomPeliniAerospike wants to merge 273 commits into
v20from
CLIENT-681-2025

Conversation

@DomPeliniAerospike

@DomPeliniAerospike DomPeliniAerospike commented May 27, 2025

Copy link
Copy Markdown
Contributor

Fix bug where only up to 4096 bytearray objects can be used in one client command

Replaces the static pool with a dynamically allocated byte pool.

TODO

  • Aim for at least 80% code coverage
  • Document where this optimization is applied, if not everywhere
  • There might be an issue where dynamic_pool.h code is duplicated and increases the wheel size. Need to double check
  • Idea where one client has its dynamic pool instead of a pool for each called command
  • Run benchmark against dev and compare

Additional tickets:
CLIENT-3501

Refactored operations and ctx code by removing hardcoded SERIALIZER_PYTHON parameters

@codecov-commenter

codecov-commenter commented May 27, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.85666% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.80%. Comparing base (e44f7bf) to head (3293bf1).
⚠️ Report is 1 commits behind head on v20.

Files with missing lines Patch % Lines
src/main/dynamic_pool.c 89.61% 8 Missing ⚠️
src/main/conversions.c 86.36% 6 Missing ⚠️
src/main/client/operate.c 94.44% 2 Missing ⚠️
src/main/client/set_xdr_filter.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              v20     #779      +/-   ##
==========================================
+ Coverage   85.76%   85.80%   +0.04%     
==========================================
  Files         102      103       +1     
  Lines       14933    15069     +136     
==========================================
+ Hits        12807    12930     +123     
- Misses       2126     2139      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/main/client/operate.c
Comment thread test/new_tests/test_cdt_index.py Outdated
… interfering with any following test cases that query the whole namespace/set to check for a user key
…values are used by default when passing a command level policy dict
…tomatically to each case using a class level decorator. this reduces the verbosity of the code
Base automatically changed from CLIENT-5338-string-list-join-op-and-expr to stage September 1, 2026 18:34
@juliannguyen4
juliannguyen4 changed the base branch from stage to v20 September 10, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants