Merge all breaking changes into stage - #1243
Draft
juliannguyen4 wants to merge 11 commits into
Draft
juliannguyen4 wants to merge 11 commits into
juliannguyen4 wants to merge 11 commits into
Conversation
…ultiple bitwise operations (#1226) Remove value_byte_size parameter for: - bit_set - bit_and - bit_or - bit_insert - bit_xor
…g if invalid map keys are used (#1227)
… other index creation methods that take in an optional ctx parameter (#1229)
…hen an invalid int argument is passed to the affected API calls in CLIENT-4678 (#1231) This affects all the API calls listed in f56000c.
…meta" dictionary parameter and have users pass ttl using policy instead (#1228) test: uncomment test case where BatchRecord Write's batch_write policy was expected to inherit from the client config batch_write policy. This bug was addressed in CLIENT-3434
…expressions in favor of RecordSize() (#1234) Both DeviceSize and MemorySize only work on server < 7.0 which is now EOL
…le scalar values (#1235)
…d of ClientError for invalid policy keys (#1230)
… be set in a config-level write policy (#1241) This affects: - config["policies"]["exists"] - config["compression_threshold"] Extra changes docs: remove references to old list and map operations in aerospike.Client that were removed in python client 12.0.0.
…as been removed in python client 6.0.0
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #1243 +/- ##
==========================================
+ Coverage 85.63% 85.72% +0.08%
==========================================
Files 102 102
Lines 15047 14860 -187
==========================================
- Hits 12886 12739 -147
+ Misses 2161 2121 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…iple config level policies (#1244) * feat!: remove socket_timeout, total_timeout, and max_retries options from client config policy dictionary. socket_timeout is not documented in this case, and total_timeout / max_retries should be set to different values depending on which command type is used e.g max_retries should be zero for non-idempotent writes, and total_timeout should be higher for batch / queries compared to single key commands * docs: remove deprecated client config commit_level option that doesn't get set for the other config-level batch policies. this setting should also vary by command type e.g due to performance reasons * feat!: remove key option from client config policies since it is also not set in the config-level batch policies * feat!: remove client config policies option replica since the docs is missing some of the command types it gets applied to, and because replica probably would be applied with different values depending on the command type * fix: rm support for client config replica option * feat!: remove read_mode_sc and read_mode_ap client config options that also dont get applied to batch_parent_write and the other command-level batch policies used for transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will rebase and merge