Micha/nodejs 24/ds 453#21
Merged
Merged
Conversation
Refresh NAN/Mocha and module registration so the addon builds and tests cleanly on Node 24, and document/update CI targets for the new runtime baseline.
Run lint, tests, and valgrind in Actions across modern Node versions so CI remains aligned with the Node 24 upgrade and current GitHub-hosted workflows.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the native addon project for Node.js 24 compatibility and migrates CI from Travis CI to GitHub Actions.
Changes:
- Updates NAN/Mocha dependencies and adds a Node 24 engine range.
- Switches the native module registration macro to the worker-enabled NAN macro.
- Replaces Travis configuration with a GitHub Actions workflow and updates README CI/runtime notes.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/native.cc |
Changes addon registration to NAN_MODULE_WORKER_ENABLED. |
README.md |
Updates CI badge and documents Node.js 24 runtime prerequisites. |
package.json |
Adds Node engine constraints, dependency updates, and script path updates. |
package-lock.json |
Refreshes locked dependency graph for updated NAN/Mocha versions. |
.travis.yml |
Removes legacy Travis CI configuration. |
.github/workflows/ci.yml |
Adds GitHub Actions CI and valgrind jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.