Skip to content

Scix 907 fix uat facet visibility - #915

Merged
shinyichen merged 3 commits into
adsabs:masterfrom
shinyichen:SCIX-907-fix-uat-facet-visibility
Sep 3, 2026
Merged

Scix 907 fix uat facet visibility#915
shinyichen merged 3 commits into
adsabs:masterfrom
shinyichen:SCIX-907-fix-uat-facet-visibility

Conversation

@shinyichen

Copy link
Copy Markdown
Member
  • Show UAT facets in heliophysics and planetary science
  • Improve binary facet. Selecting a binary facet will not show logic operators but immediate run 'limit to'.
Screen.Recording.2026-08-10.at.4.32.11.PM.mov

@shinyichen
shinyichen requested a review from thostetler August 10, 2026 23:33
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.9%. Comparing base (4c73059) to head (c362d1b).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #915     +/-   ##
========================================
+ Coverage    67.8%   67.9%   +0.1%     
========================================
  Files         378     378             
  Lines       44164   44164             
  Branches     2377    2381      +4     
========================================
+ Hits        29937   29944      +7     
+ Misses      14179   14172      -7     
  Partials       48      48             
Files with missing lines Coverage Δ
src/components/SearchFacet/config.ts 100.0% <100.0%> (ø)
src/store/slices/settings.ts 56.4% <100.0%> (+1.0%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just had the one small thing I noticed

Comment thread src/components/SearchFacet/FacetList.tsx Outdated
Comment thread src/components/SearchFacet/FacetList.tsx Outdated
@shinyichen
shinyichen force-pushed the SCIX-907-fix-uat-facet-visibility branch from 52b410d to c362d1b Compare September 3, 2026 17:53
@shinyichen
shinyichen merged commit 73ef3fb into adsabs:master Sep 3, 2026
5 checks passed
@shinyichen
shinyichen deleted the SCIX-907-fix-uat-facet-visibility branch September 3, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants