fix(schema): replace inline property-type enums with $ref in brand cluster - #6346
Open
garvitkaushik-123 wants to merge 1 commit into
Open
Conversation
…uster brand.json, verify-brand-claim-request.json, and verify-brand-claims-request.json defined property.type as an inline 8-value enum that diverged from enums/property-type.json (10 values) after PR adcontextprotocol#6280 added linear_tv and ai_assistant. Swap inline enums for $ref to the canonical enum so the brand cluster stays in sync. Update the property types list in docs/brand-protocol/brand-json.mdx to include linear_tv and ai_assistant. Add targeted schema validation tests. Closes adcontextprotocol#6330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6330
Summary
property.typeenum inbrand.jsonwith$reftoenums/property-type.json, matching the pattern already used bycore/property.jsonverify-brand-claim-request.jsonandverify-brand-claims-request.jsonwhich had identical inline copieslinear_tvandai_assistantto the brand property-type surface as a consequence of pointing at the canonical 10-value enumbrand-json.mdxdocs to list all 10 property types and reference the canonical enum fileRoot cause
brand.json(and the two verify-brand-claim schemas) definedproperty.typewith a hardcoded 8-value enum instead of using$ref. Whenlinear_tvandai_assistantwere added toenums/property-type.json, the brand cluster was missed. The inline copy drifted.Validation
node --test tests/brand-property-type-ref.test.cjs— 4/4 pass: brand.json accepts all 10 property types, rejects invalid type, both verify-brand-claim variants accept the new valuesnpm run typecheck— clean