feat(sdk): add version-pinned server and model surfaces - #1048
Merged
Conversation
bokelley
marked this pull request as ready for review
August 19, 2026 12:10
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — additive, well-tested SDK PR with no blocking or medium findings.
Checked:
- Semver signal: Public surface is additive only (version-pinned server surfaces, in-process MCP/A2A/both test builder, generated .pyi stubs, collision-safe migration aliases).
feat:is the correct signal — no removals, renames, required→optional flips, or response-shape breaks. - a2a_server change: Real fix — a2a resolves the handler pin once and threads it to both discovery (
get_tools_for_handleradcp_version) and unnegotiated dispatch (default_unnegotiated_adcp_version), matching MCP and staying backward-compatible for handlers withoutget_adcp_version. - High-risk flag: true, but all entries are
(modified)with no medium-or-higher concerns on those files. Per arbiter rules,(modified)sensitive files with no medium finding are presumed safe — no escalation on the flag alone. - Type-system layering / generated-code / credentials gates: no violations surfaced.
Findings: two Low latent items only, both omitted from blocking evaluation:
- v3_to_v4.py:517 — codemod
from_match.start(1)indexing nuance - generate_versioned_stubs.py:490 — empty TypedDict body for non-identifier-only keys
Decision table: no critical/high (row 1 no), gated_paths false (row 2 no), no (deleted) (row 3 no), no medium data-loss/schema/infra (row 4 no), no medium on modified high-risk (row 5 no), no prior escalate (row 6 no), no team gate (row 7 no), fewer than three medium (row 8 no) → row 9 approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecisioningPlatformserver surfaces and keep MCP/A2A advertisement and dispatch alignedValidation
uv run python -m pytest -q(6550 passed, 40 skipped, 9 deselected, 1 xfailed)make lintmake typecheck-allmake validate-generatedCloses #1045
Closes #1046
Closes #1047
Refs #911