Repository navigation
Let LVGL draw TileGrid cells again - #11919
Merged
Merged
Conversation
This reverts the palette lookup. Compositing stays in LVGL so it can use the hardware accelerators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Clear the whole buffer on a full compose, and each run of changed cells in a tile row otherwise, instead of one lv_draw_buf_clear() per cell. On ESP each call writes back whole buffer rows from the cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Describe how the cell clear works instead of why it changed, fix the blank-tile comment to match what the buffer is cleared to, and drop the <string.h> include that nothing uses any more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tannewt
approved these changes
Nov 19, 2026
tannewt
left a comment
Member
There was a problem hiding this comment.
Thank you! I'm excited that the P4 can do the color mapping for us!
Collaborator
Author
|
I'm pumped on color mapping too. Just to be clear for readers that is only in ESP-IDF master today (eventually 6.2 release).
The Pixel Processing Accelerator in the ESP32 chips that have can do a lot more than I originally thought. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LVGL draws TileGrid cells again, instead of a palette lookup.
Why
@tannewt asked on #11909, so LVGL's accelerators can do the drawing.
Review requests from #11909
skip_blankin_compose)Results
Metro ESP32-P4, Pi Touch Display 2, scripted playlist scroll, 3 trials.
Slightly slower than the lookup, still far ahead of before.
Written with Claude Code. Measurements are from the hardware runs above.
🤖 Generated with Claude Code