Repository navigation
web VNC display mirror fix for FramebufferDisplay under LVGL - #11911
Merged
Merged
Conversation
dhalbert
reviewed
Nov 18, 2026
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
tagging @tannewt on this:
I would hope that lvgl and classic displayio don't differ much on the internal API's. If they do maybe they should be made consistent. Here we are talking about off-by-one stuff and rotation or not.
Member
I don't really want to make area consistent because I want it to be compositor native. The rotation stuff can likely be changed in the LVGL implementation of framebuffer instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the web/VNC display mirror under LVGL for FramebufferDisplay.
This reproducer code can be used to see the issue on a Metro P4 with 5" Pi Touch Display 2:
Running on main it produces this display mirror:

With the fix it looks correct:
