Repository navigation
enable audiofilters for metro esp32-p4 - #11904
Merged
Merged
Conversation
mikeysklar
reviewed
Nov 18, 2026
Comment on lines
+13
to
+14
| CIRCUITPY_AUDIOTAP = 1 | ||
| CIRCUITPY_AUDIOFILTERS = 1 |
Collaborator
There was a problem hiding this comment.
These come from mpconfigport.mk now.
Suggested change
| CIRCUITPY_AUDIOTAP = 1 | |
| CIRCUITPY_AUDIOFILTERS = 1 |
Collaborator
|
Could you move this to the esp32p4 section of CIRCUITPY_AUDIOFILTERS ?= 1
CIRCUITPY_AUDIOTAP ?= 1
CIRCUITPY_USB_HOST_AUDIO ?= $(CIRCUITPY_USB_HOST)
|
Author
|
@mikeysklar sweet! yeah enabled it for all p4's |
mikeysklar
approved these changes
Nov 18, 2026
mikeysklar
left a comment
Collaborator
There was a problem hiding this comment.
Tested on a Metro P4 with the Pi touch display and an I2S amp. Thanks Liz!
| Test | Result |
|---|---|
| Filter (low pass, high pass) | ✅ sounds right |
| Distortion (overdrive, lofi) | ✅ sounds right |
| Phaser | ✅ sounds right |
| Display running during audio | ✅ |
| All P4 boards build | ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this enables the
audiofiltersmodule for the metro esp32-p4