Skip to content

enable audiofilters for metro esp32-p4 - #11904

Merged
mikeysklar merged 4 commits into
adafruit:mainfrom
BlitzCityDIY:p4_audiofilters
Nov 18, 2026
Merged

mikeysklar merged 4 commits into
adafruit:mainfrom
BlitzCityDIY:p4_audiofilters

Conversation

@BlitzCityDIY

Copy link
Copy Markdown

this enables the audiofilters module for the metro esp32-p4

@mikeysklar mikeysklar self-assigned this Nov 18, 2026
Comment on lines +13 to +14
CIRCUITPY_AUDIOTAP = 1
CIRCUITPY_AUDIOFILTERS = 1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These come from mpconfigport.mk now.

Suggested change
CIRCUITPY_AUDIOTAP = 1
CIRCUITPY_AUDIOFILTERS = 1

@mikeysklar

mikeysklar commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Could you move this to the esp32p4 section of ports/espressif/mpconfigport.mk, so the next P4 board gets it too? Something like this, under CIRCUITPY_AUDIOIO = 0:

CIRCUITPY_AUDIOFILTERS ?= 1
CIRCUITPY_AUDIOTAP ?= 1
CIRCUITPY_USB_HOST_AUDIO ?= $(CIRCUITPY_USB_HOST)

AUDIOTAP and USB_HOST_AUDIO are on the Metro P4 the same way, so they could move too. USB_HOST_AUDIO follows USB host, so any P4 board with CIRCUITPY_USB_HOST = 1 gets it. AUDIOFILEWRITER could move as well (ESP32-S2 already sets it port wide).

@BlitzCityDIY

Copy link
Copy Markdown
Author

@mikeysklar sweet! yeah enabled it for all p4's

@mikeysklar mikeysklar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Metro P4 with the Pi touch display and an I2S amp. Thanks Liz!

Test Result
Filter (low pass, high pass) ✅ sounds right
Distortion (overdrive, lofi) ✅ sounds right
Phaser ✅ sounds right
Display running during audio ✅
All P4 boards build ✅

@mikeysklar
mikeysklar merged commit bd93445 into adafruit:main Nov 18, 2026
290 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants