Parameterize and fix race condition for i2samp#404
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated systemd “init” unit for the I2S amplifier softvol setup so volume/control initialization can be ordered ahead of the optional /dev/zero aplay service, addressing boot-time timing/race concerns.
Changes:
- Adds an
adafruit-i2samp-init.serviceunit and wiresaplay.serviceto require it. - Updates install/uninstall logic to manage both systemd units via parameterized service-name constants.
- Adds a boot-time wait loop for the ALSA card to appear before running the init steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+204
to
+206
| After=local-fs.target | ||
| Wants=sound.target | ||
| Before={APLAY_SERVICE} |
| RestartSec=5s | ||
|
|
||
| ExecStartPre=/bin/sh -c 'i=0; while [ "$i" -lt 30 ]; do \\ | ||
| aplay -l | grep -qi "{card_name}" && exit 0; \\ |
Comment on lines
+220
to
+221
| ExecStart=/usr/bin/amixer -D plug:softvol sset PCM 100% | ||
| ExecStart=/usr/sbin/alsactl store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates the I2S Volume control as a service so that it can be started in a particular order.