Skip to content

Why a new action and not a fork / move of an existing one? #37

Description

@rajbos

Hi folks, I wanted to reach out to you on this action, seems like this is duplicating the effort of @peter-murray's excellent Action for just the same thing. I'd either expect a move of Peter's repo or a fork, instead of a rewrite. Peter's action has been the go-to for several years now, and already has features like:

  • only request a token for specific scopes
  • request a token for a different organization
  • token in another instance (GHES to GHEC for example, and any combination of the two)

Last time I checked Peter still works at GitHub, so communication should flow for this :-D.

Activity

  1. gr2m commented on Aug 29, 2023

    @gr2m
    Contributor

    We weren't aware of Peter's action 😞

    The reason why we created a new one is that it's very simple and mostly uses @octokit dependencies which I created and GitHub maintains.

    We are happy to accept outside contributions for the missing features we already identified, and also plan to contribute improvements back to actions that are in use today. For example Peter's action does not invalidate tokens in the post step yet.

  2. parkerbxyz commented on Aug 29, 2023

    @parkerbxyz
    Contributor

    This was a move of an existing repo, just not Peter's version. This repo was previously gr2m/github-app-token-action.

    There are several other GitHub Actions out there that serve the same purpose, but have different implementations:

  3. locked and limited conversation to collaborators on Aug 31, 2023
  4. converted this issue into a discussion #39 on Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions