Skip to content

[RFR] Avoid contacting twice (Fixes #28)#74

Open
thomaspaulb wants to merge 2 commits into
acsone:masterfrom
sunflowerit:fix-annotated-tags
Open

[RFR] Avoid contacting twice (Fixes #28)#74
thomaspaulb wants to merge 2 commits into
acsone:masterfrom
sunflowerit:fix-annotated-tags

Conversation

@thomaspaulb

@thomaspaulb thomaspaulb commented Jul 18, 2023

Copy link
Copy Markdown

@thomaspaulb thomaspaulb force-pushed the fix-annotated-tags branch 2 times, most recently from 8e509d5 to f4aaa32 Compare July 18, 2023 14:34
@thomaspaulb thomaspaulb changed the title [DRAFT] Support annotated tags as merge source [ADD] Support annotated tags as merge source Jul 18, 2023
vaab and others added 2 commits July 22, 2023 16:48
…csone#28)

Avoids also contacting twice (``fetch`` and then ``pull``) remote before
merging.

Signed-off-by: Valentin Lab <valentin.lab@kalysto.org>
@codecov

codecov Bot commented Jul 22, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.95062% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.61%. Comparing base (fe1e0bb) to head (9016ee7).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
git_aggregator/repo.py 83.95% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   82.64%   81.61%   -1.03%     
==========================================
  Files           6        6              
  Lines         409      457      +48     
==========================================
+ Hits          338      373      +35     
- Misses         71       84      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thomaspaulb thomaspaulb changed the title [ADD] Support annotated tags as merge source [RFR] Avoid contacting twice (Fixes #28) Jul 22, 2023
@thomaspaulb

Copy link
Copy Markdown
Author

Seems like the only cause for keeping this open is #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants