fly.io configuration - #194
Open
TheJolman wants to merge 14 commits into
Open
Conversation
godoc reference preview ready ✨
|
TheJolman
marked this pull request as draft
August 8, 2026 23:52
TheJolman
marked this pull request as ready for review
August 9, 2026 04:48
Collaborator
Author
|
@GaballaGit please check this out when you get a chance :) easiest way to test is probably by using this build of the CLI and using the |
GaballaGit
requested changes
Aug 9, 2026
| return &url.URL{ | ||
| Scheme: "http", | ||
| Host: fmt.Sprintf("%s:%s", cfg.Host, cfg.Port), | ||
| apiURL, _ := url.Parse(cfg.APIURL) |
Member
There was a problem hiding this comment.
omg trusting the Normalize func with your life 😭 . I would say potential nil pointer but the normalize func does a pretty good job at catching bad urls.
Member
|
They say this might be one of the most w prs ever |
Co-authored-by: Gaballa <lgaballal@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
live url: https://api-acmcsuf-com-black-wind-9210.fly.dev/
creates configuration for deploying on fly.io and fixes a bug for setting the URL from the CLI.
makeless noisy as well bc this was bugging menote that this deployment is just a first step, it's still in dev and therefore is unauthenticated.
Next steps: use Turso for the database, currently db is on a docker volume which works but probably isn't good enough for production.