Repository navigation
feat(chart): ship an optional Grafana dashboard - #20
Merged
Merged
Conversation
dashboards.enabled renders deploy/helm/squall/dashboards/squall.json as a ConfigMap for the kube-prometheus-stack Grafana sidecar, with dashboards.folder for the grafana_folder annotation. Off by default. The dashboard merges the three that lived in the GitOps repo, fixed: - scrape-target health and controller panels are scoped to Squall's own jobs; the job variable defaulted to every job in the cluster - Model filters use exported_namespace: the ServiceMonitor's namespace label overwrites the Model's - proxy error ratio counts rejected|failed; there is no success outcome, so every request counted as an error - provisioning failures come from the outcomes counter, not increase() on a gauge - dstack run totals are counted over the range, not raw counters Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional Grafana dashboard in the chart (
dashboards.enabled, off by default), replacing the three dashboards hand-maintained in the GitOps repo.Changes
templates/grafana-dashboards.yaml: one ConfigMap perdashboards/*.json, sidecar label configurable,grafana_folderfromdashboards.folder.dashboards/squall.json(uidsquall-overview): rows Models and proxy / dstack / Operator (collapsed).jobvariable defaulted to every job in the cluster:min(up)over 88 targets, goroutines of every Go process)exported_namespace(ServiceMonitor overwritesnamespace); documented indocs/metrics.mdrejected|failed; it usedoutcome!="success", which matches every requestsquall_model_provisioning_outcomes_total{outcome="failure"}instead ofincrease()on a gaugevalues.yaml,docs/metrics.md,CHANGELOG.md.Test Plan
helm lint;helm templatewith dashboards off (0 ConfigMaps) and on (1, label + folder annotation, JSON round-trips)🤖 Generated with Claude Code