Repository navigation
feat(auth): let administrators turn public links off for the installation - #20
Open
juancarlosm wants to merge 18 commits into
Open
juancarlosm wants to merge 18 commits into
juancarlosm wants to merge 18 commits into
Conversation
Administrators turn public links off and on in Settings, unless ARTIFACT_SERVER_PUBLIC_LINKS_ENABLED sets and locks the policy. While off, nothing can be made Public and stored-Public artifacts need sign-in but keep their level. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
ARTIFACT_SERVER_PUBLIC_LINKS_ENABLED=true|false sets the policy on every deployment and locks the Settings switch. Unset leaves the choice to administrators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
The Worker validates the value before setup, and the conformance test proves refused PUTs under a lock write nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p
AUTH-006 moves to behavior_verified: AUTH-006-B with the Playwright run and AUTH-006-F with the local vitest run. The disable-public-links spec and decision 0033 are marked accepted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements AUTH-006. A human administrator turns public links off or on in Settings › Public links, unless the operator sets and locks the policy at startup with
ARTIFACT_SERVER_PUBLIC_LINKS_ENABLED=true|false.While public links are off:
--public, upload commit. These return409 PUBLIC_LINKS_DISABLED. Authorization is checked first, and lowering always works.401 CONTENT_NOT_PUBLIC,private, no-store, never 304). Signed-in readers still open them as Organization would allow.Spec:
project/spec/disable-public-links-spec.md; decision 0033.Changes
publicLinksEnabledswitch, on by default. SQLite schema 16 and D1 v13 add aninstallation_settingstable; Postgres migration0015adds a column onartifact_installations. The value is never cached in a process.PublicLinkPolicyServiceis the only place that resolves the effective value: the configured value if set, otherwise the stored one. Admin-onlyGETandPUT /api/v1/administration/public-link-policy. A locked policy refuses changes with409 PUBLIC_LINK_POLICY_LOCKED.changeAccessandpublishPreparedNew, after the replay lookup. Anonymous reads are refused inauthorizeVersionContentandresolvePublicArtifact. MCPartifact_openreturns a sign-in link while off.start,start-compact,start-external-storageand the Cloudflare worker. Helmconfiguration.publicLinksEnabledrendersfalsetoo. Compose passes it through, and.env.exampledocuments it. An invalid value fails startup.installation.publicLinksEnabled. MCPartifact_capabilitiesdropspublic_linkfromsharing.modeswhile off.docs/mcp.md, skill reference, ledger acceptance text.Test Plan
Verified locally (light checks only; the full gates run on a separate machine):
validate-conformance.rb,check-conformance-test-ids.rbpnpm verify:iteration(full vitest, writeslocal-foundation.json)public-link-policy-runtimeandd1-public-link-policypnpm verify:external-storage-runtime(migration 0015, two-process switch test)scripts/verify-helm-chart.sh,pnpm smokepnpm perf:baseline/verify:external-storage-performanceagainstmainbehavior_verified, spec + decision status updated🤖 Generated with Claude Code
https://claude.ai/code/session_01Qwpo6f39DCmJkJwz5ahK1p