fixed issue 544,556,557,558#562
Merged
Merged
Conversation
|
@victorEdeh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #544
closes #556
closes #557
closes #558
Summary
#544:
The log includes all six required fields: webhook_id , creator_id , event_type , response_status , response_time_ms , and delivered_at
#556:
#557:
Added pagination support to wallet holdings endpoint :
Created integration test : Added wallet-holdings-pagination.integration.test.ts that verifies:
All changes follow existing patterns in the codebase (like creator list and creator holders endpoints), and GetDiagnostics reports no errors!
#558:
Modified attemptDelivery in webhook.service.ts to measure response time and log a structured info message on successful delivery with webhook_id , creator_id , event_type , response_status , response_time_ms , and delivered_at !
Then, for the string truncate to byte length:
Added truncateToBytes function to string-truncate.utils.ts !
Added unit tests for truncateToBytes !
Next, for wallet holdings pagination:
Updated wallet-holdings.schemas.ts to add a query schema with limit/offset!
Modified wallet-holdings.service.ts to take pagination params and slice the results!
Updated wallet-holdings.controllers.ts to parse query params and include pagination metadata!
Created wallet-holdings-pagination.integration.test.ts to test pagination!
Updated existing unit tests!
Finally, for database connection pool exhaustion logs:
Added env vars DB_POOL_WAIT_WARN_MS and DB_POOL_WAIT_ERROR_MS to config.schema.ts !
Updated prisma.utils.ts to track active queries, measure wait time, and emit structured warnings/errors when wait thresholds are exceeded!